Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

is plugin ignoring method references? #76

Open
62mkv opened this issue Feb 15, 2022 · 3 comments
Open

is plugin ignoring method references? #76

62mkv opened this issue Feb 15, 2022 · 3 comments
Labels

Comments

@62mkv
Copy link

62mkv commented Feb 15, 2022

I've noticed that method reference diagram is not considering method names used with "method reference syntax". This is what I get for such class:

public class DummyService {
    public Mono<String> getStringWithMethodReference() {
        return Mono.just("Hello, world")
                .map(this::processString);
    }
    public Mono<String> getStringWithLambda() {
        return Mono.just("Hello, world")
                .map(s -> processString(s));
    }
    private String processString(String source) {
        return source.toUpperCase(Locale.ROOT);
    }
}

image

PS: by the way, I would like to be able to contribute a fix for this, so if there're any hints/suggestions, please share! I did not yet take a look at the code though..

@Stefku
Copy link
Owner

Stefku commented Feb 15, 2022

Hi @62mkv, you probably found a bug. Thanks for reporting.

You are very welcome to contribute. I think a good point to start is ReferenceDiagramDataModel. The constructor gets called with a PsiClass where the user wanted to render the diagram. Give it a try and come back to me if you struggle.

@Stefku Stefku added the bug label Feb 15, 2022
@62mkv
Copy link
Author

62mkv commented Feb 15, 2022

Hi @Stefku only having cloned the project, I realized that it's purely for Ultimate which unfortunately means I can not contribute to this awesome project, as I only have IC edition at home! Will buy you coffee instead!

@Stefku
Copy link
Owner

Stefku commented Feb 16, 2022

Yes, since JetBrains has licensed the diagram library, the plugin is just for Ultimate version. I would know a good and easy to use possibility of a free open source library we could change it (see also #56).

Thanks for the coffee @62mkv! I really appreciate it! I'm glad, that other people also have the use for this plugin.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants