Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

v11 Update #61

Open
SirMotte opened this issue Oct 16, 2022 · 11 comments
Open

v11 Update #61

SirMotte opened this issue Oct 16, 2022 · 11 comments

Comments

@SirMotte
Copy link

SirMotte commented Oct 16, 2022

Are there any plans to update this incredible module to v10 v11 in the foreseeable future?

@jagoe
Copy link

jagoe commented Nov 18, 2022

It seems that the only thing breaking the module is a missing default value for one of the settings (askRollType). Once that's added, it seems to run as expected.
Can't be a 100% certain though since I've never used this module before.

@pinkflumph
Copy link

It seems that the only thing breaking the module is a missing default value for one of the settings (askRollType). Once that's added, it seems to run as expected. Can't be a 100% certain though since I've never used this module before.

Hey @jagoe, can you please clarify? I'm new to Foundry, and you seem to describe it as though you fixed the issue on your end, can you write down the steps to do that? With two summoners in my party, I need this module
Thanks!

@jagoe
Copy link

jagoe commented Nov 26, 2022

Hey @pinkflumph, I might be able to help you if you host Foundry yourself. If you don't, you'll have to wait for an official release.
I'll post my changeset and a short description of how to apply it within the next couple days.

@jagoe
Copy link

jagoe commented Nov 27, 2022

@pinkflumph Here's the change that I was talking about.

If you're hosting Foundry yourself, you should find the file in your data directory in Data/modules/mob-attack-tool/scripts/settings.js. Once you add the line, you can start or refresh Foundry and the module should load without error.
But as I said earlier, I can't guarantee there won't be other compatibility issues as I never used the module.

Also, hopefully needless to say, I won't be held responsible if anything breaks on your end. You should definitely make a backup of your world before making the change.

@daft-develop
Copy link

PR for v10 changes
#63

You can update to this fork to run in v10 until @Stendarpaval confirms v10 status on the official project.
https://raw.githubusercontent.com/daft-develop/mob-attack-tool/main/module.json

@daft-develop
Copy link

@SirMotte SirMotte changed the title v10 Update ~~v10~~ v11 Update Aug 22, 2023
@SirMotte SirMotte changed the title ~~v10~~ v11 Update v11 Update Aug 22, 2023
@SirMotte
Copy link
Author

SirMotte commented Aug 22, 2023

Updated fork for v11 support

https://github.com/daft-develop/mob-attack-tool/releases/download/0.5.0/module.json

Awesome, gonna try it out asap. Thank you so much for keeping the module alive.

@Shambles1337
Copy link

Shambles1337 commented Apr 18, 2024

I am on Version 11 Stable Build 315 and sadly it's not working for me. I even spun up a new world and disabled all other modules except mob attack tool and LibWrapper and it still didn't work. Is there any update needed?

Edit: I should add, the tool appears, and I can select and target mobs, but when i click "mob attack" the window closes and nothing happens.

@daft-develop
Copy link

Hey @Shambles1337, I can confirm I see something similar but not exactly the same as you. It might be a slight difference in setup or something else I've missed:

Working case: Foundry v11.315, Mob Attack v0.5.0, and D&D 5e 2.4.1 (or probably anything 2.x), no other modules enabled (other than LibWrapper:

  • After dialogue chat cards for attack rolls and damage show as expected
    working

Current latest is breaking: All same as before but updated to D&D 5e 3.x
NotWorking
The attack summary card seems to be failing, I suspect with the 5e 3.x "chat enrichment" that was added something broke it. On my end it's still following through with showing the damage (if any attacks landed), or displays the attack card if everything missed.
AllMisses

Maybe your settings are different than mine? Then I can try to recreate your exact setup:
settings

Regardless, if you could open this as a new issue on my fork (https://github.com/daft-develop/mob-attack-tool/issues) that'll prevent this issue ticket from getting too long. I'll see if I can sort out the issue I'm seeing and push a new release this weekend.

@daft-develop
Copy link

New update for compatibility with v11 and 5e system version 3.x (attack cards weren't showing)

https://github.com/daft-develop/mob-attack-tool/releases/download/0.6.0/module.json

@daft-develop
Copy link

As a general heads up, I've been granted permission from Foundry staff on the ownership of this project and have updated the official Foundry module page to point to my repo fork instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants