Fixed possible negative duration #8
Conversation
Distance in this framework are algebraic, they can either be positive or negative. Thus the calculated duration could be negative which is interpreted as a null duration.
|
@iDonJose Thanks for the kind words, and glad that you're enjoying using TweenKit! Good spot! This is a good fix, I'm going to merge it in. This really exposes an inconsistency in the way that I've implemented the Really it should be consistent, so I might change all of them to return positive values. It's still a good idea to have this check in too, to avoid bugs when users of the library implement their own You are officially the second contributor to TweenKit! 🎉 Thanks for helping to improve it! 👍 |
|
I'll have a look at your other PR's, although I'm just about to go on holiday for the next couple of weeks, so if you don't hear from me then just give me a bit more time to get round to it. I'll aim to do another release to CocoaPods when I'm back 👍 |
|
@SteveBarnegren Ok ! Wish you happy Hollidays and Christmas time. That's what I was thinking too. Distance should be returning only positive values as it used only for calculating duration at the moment. I'll send you a PR. |
Hello Steve, this is a really a nice framework that your offer us !
In the many animation frameworks available on Github I've chose yours as it's really clean, simple to use and powerful.
Now comes a bunch of updates I want to bring to better TweenKit !
Here we fix the duration. It needs to be positive and distance between the two values is algebraic.