-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Vogen 3.0.21 -> 3.0.22 - Compilation Error on Custom Equality #516
Comments
Apologies @cmeyertons - I completely missed this scenario. I'll fix ASAP. |
The 2nd beta is there now on NuGet: https://www.nuget.org/packages/Vogen/3.0.23-beta.2 |
No worries at all! Appreciate the quick fix, no rush on my end. Just like to stay up-to-date |
Sorry @cmeyertons - the comment above was meant for another issue. I'm taking a look at this issue now. Previously, for records, GetHashCode and Equals were not generated because this was auto-generated as part of the record. But there was a feature request to support case-insensitive comparison and as part of that, I made the change to bring records more in line with classes and structs. It seems reasonable to allow users to provide their own Regarding This causes a problem for Vogen if users have supplied their own I'm wondering, before I start the work on checking for overloaded Equals methods (and probably the |
Thanks for the report @cmeyertons - this is now fixed in 3.0.23 - apologies for the mess up. I've documented what can be overridden here: https://github.com/SteveDunn/Vogen/wiki/Overriding-methods |
Describe the bug
We have a Value Object that implements its own
Equals
andGetHashCode
and it fails to compile when upgrading from 3.0.21 -> 3.0.22Steps to reproduce
Error message:
Expected behaviour
For a patch version release, I would not expect this kind of breakage.
The text was updated successfully, but these errors were encountered: