Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ROS2] Replace publishers with msg references with unique_ptrs #201

Closed
SteveMacenski opened this issue May 2, 2020 · 0 comments · Fixed by #251
Closed

[ROS2] Replace publishers with msg references with unique_ptrs #201

SteveMacenski opened this issue May 2, 2020 · 0 comments · Fixed by #251
Labels
enhancement New feature or request

Comments

@SteveMacenski
Copy link
Owner

Right now, all the publishers use the message reference API for publishing information. If using intra-process components, that will incur a copy. For inter-process it adds jitter to the system. We publish large messages here regularly and we should do this for a reasonably large performance boost.

Ref: ros-drivers/ros2_ouster_drivers#41 on discussion and also how to change to the other API with std::move.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant