Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radio inputs don't work in Internet Explorer 7 #197

Closed
scottmessinger opened this issue Nov 5, 2011 · 2 comments
Closed

Radio inputs don't work in Internet Explorer 7 #197

scottmessinger opened this issue Nov 5, 2011 · 2 comments

Comments

@scottmessinger
Copy link

I'm seeing an issue with IE7 radio buttons. To replicate:

  1. Open: http://knockoutjs.com/examples/animatedTransitions.html
  2. Click "Display advanced options"
  3. Try to choose one of the radio options.

If your IE7 works like mine, you shouldn't be able to select the radio buttons.

I'm using IE 7.00.5730.13

Any ideas what's going on?

@isleigh
Copy link

isleigh commented Nov 6, 2011

I think this is linked to this #195

In the checked binding this code runs

// IE 6 won't allow radio buttons to be selected unless they have a name
    if ((element.type == "radio") && !element.name)
        ko.bindingHandlers['uniqueName']['init'](element, function() { return true });

and the uniqueName doesnt work for ie7 (it has an ie6 specific fix)

If you inspect the generated list elements (eg using IE Developer toolbar) you will see that they dont have a name attribute which is required for radio groups to work

SteveSanderson added a commit that referenced this issue Nov 7, 2011
…pro the original bug, you have to run a real IE7 instance, *not* IE9 in IE7 mode.
@SteveSanderson
Copy link
Contributor

Thanks for reporting this, and for correctly diagnosing the cause. It's now fixed in the latest source code.

The reason this wasn't found before is that it only happens when you run a real IE7 instance, and not when you run IE9 in IE7 mode... :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants