Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

New list sources #1347

Closed
hyder365 opened this issue Jul 11, 2020 · 11 comments
Closed

New list sources #1347

hyder365 opened this issue Jul 11, 2020 · 11 comments
Labels

Comments

@hyder365
Copy link

Hello. A few (well, a lot of) ad/malware domains have been compiled by the OpenWRT project:

https://github.com/openwrt/packages/blob/master/net/adblock/files/README.md

Could these be absorbed into this repo and regularly synced?

@welcome
Copy link

welcome bot commented Jul 11, 2020

Hello! Thank you for opening your first issue in this repo. It’s people like you who make these host files better!

@StevenBlack
Copy link
Owner

Hi @hyder365 thank you for this suggestion.

Several of our sources, including our amalgamated list, are in that list.

Which component of that list do you recommend absorbing here?

Our main criteria is, the lists we carry are all actively curated. We aren't interested in add-only buckets of countless domain names. Quality, for us, comes from active curation.

@hyder365
Copy link
Author

In particular I'm interested in the adguard list, which is well known and actively maintained. Slightly less important, but still nice to have, would be the ones specializing in mobile ads,YouTube ads, and smart TV telemetry. Many of the non-English lists, bitcoin miners, and so on are less important.

@StevenBlack
Copy link
Owner

@hyder365 we've talked about AdGuard before, particularly in Issue #1181. Review that, so you're up-to-speed.

I think AdGuard would be a good addition. I have concerns about how this list is properly curated.

@hyder365
Copy link
Author

Thanks for the link. Even without AdGuard, some of these would be nice to add.

The YouTube one (https://github.com/kboghdady/youTube_ads_4_pi-hole) has made a big difference here!

@stale
Copy link

stale bot commented Nov 13, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Nov 13, 2020
@StevenBlack
Copy link
Owner

I'm considering adding several new sources, and this is one of them.

@stale stale bot removed the wontfix label Nov 13, 2020
@dnmTX
Copy link
Contributor

dnmTX commented Nov 13, 2020

I'm considering adding several new sources, and this is one of them.

Steve @StevenBlack i've read some of the issues: example.
Doesn't look like it works for everyone with some stating that the videos can't even start playing. Also the curator recommends
the list to be updated at least daily. Not sure that you want go trough that hassle.

@StevenBlack
Copy link
Owner

Thanks Dan @dnmTX that clarifies things for me.

@stale
Copy link

stale bot commented Mar 15, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed in 14 days if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Mar 15, 2021
@stale
Copy link

stale bot commented Mar 29, 2021

Closing.

@stale stale bot closed this as completed Mar 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

3 participants