Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rewrite the current style names in pure to be more compatible with css modules #1

Open
svnm opened this issue Nov 23, 2015 · 1 comment

Comments

@svnm
Copy link
Owner

svnm commented Nov 23, 2015

The class names in pure css are not suited to css modules, and could be made much more compact.

@svnm
Copy link
Owner Author

svnm commented Nov 23, 2015

Moving this from the README...

It may be something to consider in the future, however would need some discussion with the developers at purecss to ensure they are on board with a new version being written as currently the css source in this module is just a straight copy from purecss 0.6.0 cdn exported as modules for use in components.

It would mean instead of css styleNames like this:

<button styleName='pure-button pure-button-disabled'>A Disabled Button</button>

we could write:

<button styleName='button-disabled'>A Disabled Button</button>

which would obviously be much nicer

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant