Fix NoMethodError if callback is conditional and aborts using throw #19
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`false` instead of a number if one of the callbacks has a "filter" (so a conditional if: or unless: key) and does a `throw(:abort)` to halt the callback sequence. This error is caused in /activesupport/lib/active_support/callbacks.rb:130 but since it is part of the internal API there is no sense in reporting that issue.
… error with ruby 2.5.0
|
The changes to travis config were prompted by this. |
stex
approved these changes
Sep 26, 2019
| @@ -83,7 +83,9 @@ def changed_attributes | |||
| def _update_record(*) | |||
| super.tap do |affected_rows| | |||
| # Workaround to trigger a #touch if necessary, see +after_save+ callback further up | |||
| @_setting_accessors_touch_assignable = affected_rows.zero? | |||
| # The callback chain can, if a filter was provided for a certain callback and the callback throws and :abort, | |||
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added a test and a fix for an issue where
_update_recordmay returnfalseinstead of a number if one of the callbacks has a "filter" (so aconditional if: or unless: key) and does a
throw(:abort)to halt thecallback sequence.
This error is caused in
/activesupport/lib/active_support/callbacks.rb:130
but since it is part of the internal API there is no sense in reporting
that issue.