Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade Catch2 to v3 #158

Closed
eao197 opened this issue May 19, 2022 · 3 comments
Closed

Upgrade Catch2 to v3 #158

eao197 opened this issue May 19, 2022 · 3 comments
Assignees
Milestone

Comments

@eao197
Copy link
Member

eao197 commented May 19, 2022

Catch2 library is used as unit-test framework in the RESTinio development.

Since v3 Catch2 is no more header-only library: https://github.com/catchorg/Catch2/releases/tag/v3.0.1

RESTinio have to be updated to Catch2 after Catch2-v3 will be stabilized and got a few correcting releases.

@eao197 eao197 self-assigned this May 19, 2022
@barracuda156
Copy link

And currently tests fail due to non-existent header:

fatal error: catch2/catch.hpp: No such file or directory
    5 | #include <catch2/catch.hpp>
      |          ^~~~~~~~~~~~~~~~~~
compilation terminated.

Correct name is catch_all.h.

@eao197
Copy link
Member Author

eao197 commented Aug 25, 2023

It seem that we can't add support for Catch2-v3 for CMake and MxxRu: Catch2-v3 requires generation of catch_user_config.hpp from catch_user_config.hpp.in during the configure phase. This is simply not possible with MxxRu.

So we have to drop MxxRu support.

It's not a problem. But I'm afraid we can't do that in 0.6 branch. So the support for Catch2-v3 will wait until the work on 0.7 branch will be started :(

@eao197 eao197 added this to the 0.7.0 milestone Oct 31, 2023
@eao197
Copy link
Member Author

eao197 commented Nov 13, 2023

Catch2 v3 is used since v.0.7.0.

@eao197 eao197 closed this as completed Nov 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants