Skip to content
This repository has been archived by the owner on Apr 22, 2024. It is now read-only.

Write unit tests #1

Open
Stiivi opened this issue Feb 20, 2017 · 3 comments
Open

Write unit tests #1

Stiivi opened this issue Feb 20, 2017 · 3 comments

Comments

@Stiivi
Copy link
Owner

Stiivi commented Feb 20, 2017

Reason for not yet having unit tests: "generated output compiles correctly" is sufficient for the time being. However, this might not be very sustainable in the long-run.

@wizzat
Copy link

wizzat commented Feb 20, 2017

You need a couple of "end to end" unit tests for the purposes of describing what the input and outputs look like.

@Stiivi
Copy link
Owner Author

Stiivi commented Feb 20, 2017

@wizzat agreed, will add them gradually as the idea stabilizes. This is still proof-of-concept/prototype.

Just to get an idea how the current Python output looks like for the included example, here is the generated file.

Might be not a bad idea to add small shell script that would:

  1. generate few Python outputs
  2. run the Python outputs through mypy and maybe some additional linters

@wizzat
Copy link

wizzat commented Feb 20, 2017

Sounds like a solid idea - the faster you get something like that in place the less painful it will be to fix it when it invariably breaks.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

2 participants