Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change minify requirement to a newer version #44

Closed
Joshua-F opened this issue Nov 10, 2014 · 5 comments
Closed

Change minify requirement to a newer version #44

Joshua-F opened this issue Nov 10, 2014 · 5 comments

Comments

@Joshua-F
Copy link

I've been trying to find out the problem when minifying a specific file and finally found the issue, which appears has been fixed in a newer version of mrclay/minify found here.

Issue found here.

It would be nice if you updated the composer file here so that commit will be used.

@stevunk
Copy link

stevunk commented Nov 10, 2014

bump

@Stolz
Copy link
Owner

Stolz commented Nov 10, 2014

Those changes have not yet been merged into any of the mrclay/minify versions available via composer other than the "dev-master". I wouldn't mind to base my work on develop branches as long as they are numbered. "dev-master" is not numbered. The latest numbered version of mrclay/minify is 3.0.x-dev bce6fac, which still uses cssmin.php v2.4.8-2 and not v2.4.8-4.

I keep this issue open until those changes are merged to a numbered version installable via composer. If you notice the changes are included in any numbered release please let me know.

@Stolz
Copy link
Owner

Stolz commented Mar 6, 2015

I'm closing this. mrclay/minify development seems stalled. You should open an issue on that repo asking for a composer release with the latest changes.

@Joshua-F
Copy link
Author

Joshua-F commented Mar 8, 2015

mrclay has tagged 2.2.1

@Stolz
Copy link
Owner

Stolz commented Mar 9, 2015

Perfect. Then no change should be needed as current composer.json requires mrclay/minify ~2.1, which includes 2.2.1. A standard composer update should bring the new mrclay/minify version.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants