Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change package to point at build/jssm.es5.js #291

Closed
StoneCypher opened this issue Aug 20, 2017 · 1 comment
Closed

Change package to point at build/jssm.es5.js #291

StoneCypher opened this issue Aug 20, 2017 · 1 comment

Comments

@StoneCypher
Copy link
Owner

So

If you're packaging your own downstream, from node which today does not have import, this is what you want

If you're packaging the es6 yourself, then the src copy is what you want

If you're pulling for a browser, and/or from a CDN, the cjs copy in dist is what you want

This fixes the issue in #290 as a result

This seems to be principle of least surprise? It's a hard call. A document section will be needed. This will need to change, probably invoking a major, in the import era.

@StoneCypher
Copy link
Owner Author

i should maybe declare a major here? but i'm not very confident this will stay

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant