Merge pull request #229 from bookchin/bug/trailing-space-uri

v1.3.5 (fix whitespace issue in url when opening a datachannel)
storj-archived · Jun 29, 2016 · 9c59fbc · 9c59fbc
2 parents 511adae + e4698f0
commit 9c59fbc
Show file tree

Hide file tree

Showing 3 changed files with 13 additions and 2 deletions.
diff --git a/lib/datachannel/client.js b/lib/datachannel/client.js
@@ -160,7 +160,7 @@ DataChannelClient.getChannelURL = function(contact) {
   return url.format({
     protocol: 'ws',
     slashes: true,
-    hostname: contact.address,
+    hostname: contact.address.trim(),
     port: contact.port
   });
 };

diff --git a/package.json b/package.json
@@ -1,6 +1,6 @@
 {
   "name": "storj",
-  "version": "1.3.4",
+  "version": "1.3.5",
   "description": "implementation of the storj protocol for node.js and the browser",
   "main": "index.js",
   "directories": {

diff --git a/test/datachannel/client.unit.js b/test/datachannel/client.unit.js
@@ -163,3 +163,14 @@ describe('DataChannelClient', function() {
   });
 
 });
+
+describe('DataChannelClient#getChannelURL', function() {
+
+  it('should create url and trim whitespace from address', function() {
+    expect(DataChannelClient.getChannelURL({
+      address: ' 127.0.0.1  ',
+      port: 1337
+    })).to.equal('ws://127.0.0.1:1337');
+  });
+
+});