Update app.py #29
Merged
Update app.py #29
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Since text is static, no need to redefine in every for loop. Add a total_height at the very end.
|
I agree on your first point, but the total height is already covered by the new |
Define text outside of the for loop, since it is static.
|
@changetip 1000 bits. Thanks! |
|
Hi @NicoNet, @super3 sent you a Bitcoin tip worth 1000 bits ($0.27), and I'm here to deliver it ➔ collect your tip. |
|
@NicoNet You left the total_height var in there. |
remove the total_height
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since text is static, no need to redefine in every for loop.
Add a total_height at the very end of output.