Merge pull request #144 from braydonf/max-shard-size

Add max shard size
storj-archived · Jan 3, 2018 · 52b6cd7 · 52b6cd7
2 parents 4dd6c81 + 4586a77
commit 52b6cd7
Show file tree

Hide file tree

Showing 3 changed files with 34 additions and 0 deletions.
diff --git a/lib/constants.js b/lib/constants.js
@@ -54,6 +54,7 @@ module.exports = {
     OTHER: 'adjustment'
   },
   MIN_SHARD_SIZE: 15360,
+  MAX_SHARD_SIZE: 4294967296,
   MAX_REPUTATION_POINTS: 5000,
   MIN_REPUTATION_POINTS: 0,
   POINTS: {

diff --git a/lib/models/frame.js b/lib/models/frame.js
@@ -89,6 +89,11 @@ Frame.statics.validShardSizes = function(shards) {
         return false;
       }
     }
+    for (let i = 0; i < shards.length; i++) {
+      if (shards[i].size > constants.MAX_SHARD_SIZE) {
+        return false;
+      }
+    }
   }
   return true;
 };

diff --git a/test/frame.unit.js b/test/frame.unit.js
@@ -395,6 +395,34 @@ describe('Storage/models/Frame', function() {
       expect(Frame.validShardSizes(shards)).to.equal(false);
     });
 
+    it('it should reject max shard sizes', function() {
+      const shards = [
+        {
+          index: 0,
+          size: 4294967297
+        },
+        {
+          index: 1,
+          size: 4294967297
+        },
+        {
+          index: 2,
+          size: 30000
+        },
+        {
+          index: 3,
+          size: 4294967297,
+          parity: true
+        },
+        {
+          index: 4,
+          size: 4294967297,
+          parity: true
+        }
+      ];
+      expect(Frame.validShardSizes(shards)).to.equal(false);
+    });
+
   });
 
   describe('#addShard', function() {