Remove calculation of deterministic id #148
Conversation
| // XXX DEPRECATION IN NEXT MAJOR RELEASE | ||
| // XXX The determinitic id will be deprecated and the index field will | ||
| // XXX become required for any new bucket entries. This is to make sure | ||
| // XXX that each bucket entry will have a unique id. | ||
| if (index) { |
There was a problem hiding this comment.
We may want to validate that the index exists, I think this was the plan from before. Will need to test to check.
There was a problem hiding this comment.
And this is actually done by calling this isValidIndex() function from the create() function, right? (Line 117 after changes) Or did you mean something different?
There was a problem hiding this comment.
I think by removing the if statement for if (index), but will need to check that this is okay.
There was a problem hiding this comment.
The PATCH method in the bridge will check if there is an index. If there isn't one, it will return Unprocessable Entity Error. So it would be safe to continue creating bucket entries without index. Simply, it won't be possible to rename them afterwards.
However, if you want to force clients to create only bucket entries with index, we should remove the if (index).
|
There is a minor merge conflict on this in the package.json, FYI |
|
Resolved. |
Related to storj-archived/bridge#488