This repository has been archived by the owner on Oct 30, 2018. It is now read-only.
Referrals updates #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erral_id for referral credits
…d count to track multiple sends
bryanchriswhite
approved these changes
Feb 19, 2017
|
LGTM. Merging. |
|
Is this not work-in-progress (e.g. not ready to merge) as with the WIP in the title? Looks like there is API/model change here that will need major bump, and code coverage decreased. |
|
@dylanlott & @barbaraliau , can you please remove WIP from this MR and discuss with @braydonf the API change and where the version should land for this? I can re-publish (unpublish and publish) the version that is decided upon. |
braydonf
reviewed
Feb 22, 2017
| 'recipient.email': recipientEmail | ||
| }).then((referral) => { | ||
| if (referral) { | ||
| referral.count += referral.count; |
There was a problem hiding this comment.
There may be a concurrency issue here if two processes do this at the same time, one of the count will go missing.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Referrals updates