This repository has been archived by the owner on Oct 30, 2018. It is now read-only.
sketchy validator patch #84
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
What up with this? There are some known issues with the regex #75 but what issue is this solving? |
braydonf
suggested changes
Mar 17, 2017
| @@ -22,11 +22,7 @@ var StorageEvent = new mongoose.Schema({ | |||
| user: { | |||
| type: String, | |||
| ref: 'User', | |||
| required: true, | |||
There was a problem hiding this comment.
This should remain as true. And email validation should be consistent across all models. The validation should be fixed not removed.
There was a problem hiding this comment.
@braydonf it is still true.. see line 25
There was a problem hiding this comment.
Oh... okay. But why remove the validation?
|
We may want to relax the regex to only care about the maximum length of the characters (<64 characters>@<255 characters>), as mentioned in #45. Validation will ultimately be tested by if the address can receive email. |
|
This is a temporary fix... Merging. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.