This repository has been archived by the owner on Oct 30, 2018. It is now read-only.
[WIP] Repair config on read #202
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Is this still a WIP? |
|
I don't think so but it needs testing. Not logged into GitHub on my phone.
…On Mon, Aug 28, 2017, 10:23 AM Alexander Leitner ***@***.***> wrote:
Is this still a WIP?
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#202 (comment)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AMV8Z0_VxKSz6rwFFTGthGs1e9-NEl5_ks5scs1igaJpZM4Ob-BC>
.
|
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
_isValidSize()function to be more correctstorageAllocationdoesn't have a size specifier, default to bytes and addBto the end of the value. This could be left over from older configs.