Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

roof goes through building #18

Closed
ivanbranco opened this issue May 3, 2023 · 5 comments
Closed

roof goes through building #18

ivanbranco opened this issue May 3, 2023 · 5 comments
Labels
bug Something isn't working

Comments

@ivanbranco
Copy link
Contributor

ivanbranco commented May 3, 2023

I have a problem with this relation (Streets GL URL), I don't understand if I did something wrong or if is a problem with the renderer.

The last floor (the second: way252607457) is min_height=3 + height=5.7
the roof is min_height=5.7 + height=8.7 (w247047014)

shouldn't this be fine?

image

@StrandedKitty StrandedKitty added the bug Something isn't working label May 3, 2023
@StrandedKitty
Copy link
Owner

Thank you for reporting this. The problem was that this roof doesn't have a height tag, and default roof height didn't take into account building height and min_height.

Fixed in 400e0fc.

@ivanbranco
Copy link
Contributor Author

Thank you for fixing it!

The problem was that this roof doesn't have a height tag,

I don't understand tho, the roof building:part does have height=8.7, why you say it doesn't?

@StrandedKitty
Copy link
Owner

Sorry, I was referring to roof:height. The roof (https://www.openstreetmap.org/way/247047014/history) doesn't have this tag so the renderer needs to guess.

@ivanbranco
Copy link
Contributor Author

ivanbranco commented May 3, 2023

Uhm, I understand its use when a building/building:part has a facade and a roof. But with building:part=roof there's no facade, that's why I used height only. Thanks for the explanation

@StrandedKitty
Copy link
Owner

Hmm, I guess you are right. I didn't think of it this way. So many edge cases...

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants