Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Linking article which is a redirect fails to fetch the introduction #21

Closed
redactedscribe opened this issue Nov 18, 2023 · 4 comments
Assignees
Labels
bug Something isn't working

Comments

@redactedscribe
Copy link

Description

I use {description} in my template and if I try to link an article which does not have one, the insertion of the template fails.

To Reproduce

  • Link an article which has no description with {description} in your template.

Expected Behavior

The expectation is that something would be inserted because the article itself exists, just skip over inserting the description and pop up an error saying that no description was inserted because one didn't exist for the article.

Thanks.

@redactedscribe redactedscribe added the bug Something isn't working label Nov 18, 2023
@StrangeGirlMurph
Copy link
Owner

For me it works just as expected. It just ignores the {description} when there is no description and tells you about it. This must be some different bug or something specific about the article you were trying to link. Please tell me what article caused this and check the console for any errors (use CTRL+SHIFT+I and then go to the console tab).

@redactedscribe
Copy link
Author

redactedscribe commented Nov 18, 2023

On second look, it also says it couldn't fetch the introduction:

Obsidian_2023-11-18_17-31-44

It's actually nothing to do with {description} in fact. The introduction on the article for File Type is the issue, and if I had to guess, it's because it's a redirect to another article (File format). Edit: Inserting the File format article works without issue.

@redactedscribe redactedscribe changed the title [BUG] Linking article fails if article has no description and template contains {description} [BUG] Linking article which is a redirect fails to fetch the introduction Nov 18, 2023
@StrangeGirlMurph
Copy link
Owner

StrangeGirlMurph commented Nov 18, 2023

I fixed it! It was actually a pretty big bug. Sorry I haven't noticed it myself. Thank you so much for creating this issue!
You can update your plugin now! https://github.com/StrangeGirlMurph/obsidian-wikipedia-search/releases/tag/2.3.0

@redactedscribe
Copy link
Author

Thanks @StrangeGirlMurph!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants