Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Logging before raise exception #21

Closed
butorov opened this issue Aug 30, 2016 · 0 comments
Closed

Logging before raise exception #21

butorov opened this issue Aug 30, 2016 · 0 comments
Assignees
@Stranger6667
Milestone
0.3.1

Comments

@butorov
Copy link

butorov commented Aug 30, 2016

https://github.com/Stranger6667/pyoffers/blob/master/pyoffers/api.py#L85

In case of 4XX, 5XX response code we will lose information about content and code of response.
I think that would be better write log before make raise_for_status().
@Stranger6667 Stranger6667 added this to the 0.3.1 milestone Aug 30, 2016
@Stranger6667 Stranger6667 self-assigned this Aug 30, 2016
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Stranger6667 Stranger6667

Labels
None yet
Projects
None yet
Milestone
0.3.1
Development

No branches or pull requests
2 participants
@Stranger6667 @butorov