Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bug: Hammer doesn't ignore specific characters inside text key value #594

Closed
BonkManReturns opened this issue Oct 12, 2022 · 1 comment
Closed
Labels
Type: Bug This is a problem with something that should be working one way, but isn't.

Comments

@BonkManReturns
Copy link

Describe the bug

Placing symbols such as quotation marks inside the key value of various entities (In this case, a text value) results in the vmf crashing (In this case, it blamed line 37924 instead of the culprit, line 37918).
sign_pmamremake
The vmf code, with the error happening to a prop_testchamber_sign in P2CE.
errorbaby
The crash message.

To Reproduce

Simply place quotation marks inside a text key value, such as the P2CE testchamber_sign sign_levelname key.

Issue Map

https://drive.google.com/file/d/1Gegw_9bgn-LACmqw34SB3zWCbsx4smx3/view?usp=sharing

Expected Behavior

Hammer should naturally escape these characters (Thanks to Erin for the explanation).

Operating System

Windows 10

@BonkManReturns BonkManReturns added the Type: Bug This is a problem with something that should be working one way, but isn't. label Oct 12, 2022
@lvaness
Copy link
Member

lvaness commented Oct 12, 2022

Duplicate of #60

@lvaness lvaness marked this as a duplicate of #60 Oct 12, 2022
@lvaness lvaness closed this as not planned Won't fix, can't repro, duplicate, stale Oct 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Type: Bug This is a problem with something that should be working one way, but isn't.
Projects
None yet
Development

No branches or pull requests

2 participants