This repository has been archived by the owner on Nov 20, 2019. It is now read-only.
[CROSSDATA-818]Removed Server config as trait #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pianista215
changed the title
pfcoperez
approved these changes
Nov 15, 2016
| class ServerActor(cluster: Cluster, sessionProvider: XDSessionProvider) | ||
| extends Actor with ServerConfig { | ||
| class ServerActor(cluster: Cluster, sessionProvider: XDSessionProvider, serverConfig: ServerConfig) | ||
| extends Actor { |
There was a problem hiding this comment.
This is a silly style preference: In order to minimize changes here and avoid some repetitions, you could import your config attributes:
import serverConfig._
darroyocazorla
approved these changes
Nov 16, 2016
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Changing the inheritance of "ServerConfig" to a composition pattern
Testing
Documentation