Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libwebp missing in 5.36 and 5.38 #125

Open
dk opened this issue Aug 7, 2023 · 1 comment
Open

libwebp missing in 5.36 and 5.38 #125

dk opened this issue Aug 7, 2023 · 1 comment

Comments

@dk
Copy link

dk commented Aug 7, 2023

First of all, thank you all for picking up the project and making new releases - these were missed badly!

I asked previously kmx to include libwebp into SP distro, as my project depends on these, and until 5.32 it had libwebp, libwebpdemux, and libwebpmux libraries. Would it be possible to add these to 5.38 as well?

I would gladly submit a patch but I can't figure out what's needed for this - share/64bit-5.38.0.1.pp points to the URLs that are also part of the build, so I guess something like this is needed but is not enough:

diff --git a/share/64bit-5.38.0.1.pp b/share/64bit-5.38.0.1.pp
index 45ae657..22bdabf 100644
--- a/share/64bit-5.38.0.1.pp
+++ b/share/64bit-5.38.0.1.pp
@@ -31,6 +31,7 @@
             mpc  => 'https://github.com/StrawberryPerl/build-extlibs/releases/download/dev_gcc13.1_20230606/64bit_mpc-1.3.1-bin_20230606.zip',
             mpfr => 'https://github.com/StrawberryPerl/build-extlibs/releases/download/dev_gcc13.1_20230606/64bit_mpfr-4.2.0-bin_20230606.zip',
             libgd           => 'https://github.com/StrawberryPerl/build-extlibs/releases/download/dev_gcc13.1_20230502/64bit_libgd-2.3.2-bin_20230502.zip',
+            libwebp => 'https://github.com/StrawberryPerl/build-extlibs/releases/download/dev_gcc13.1_20230606/64bit_libwebp-1.1.0-bin_20200712.zip',
             zgdb => 'https://github.com/StrawberryPerl/build-extlibs/releases/download/dev_gcc13.1_20230606/64bit_gdb-13.1-bin_20230626.zip',
             termcap => 'https://github.com/StrawberryPerl/build-extlibs/releases/download/dev_gcc13.1_20230606/64bit_termcap-1.3.1-bin_20230606.zip',
         },
@shawnlaffan
Copy link
Contributor

Thanks for the report. It seems libwebp was overlooked in the builds.

I've opened StrawberryPerl/build-extlibs#52 to track it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants