Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Extract Encoders to a separate modules #39

Closed
Strech opened this issue Jun 19, 2020 · 1 comment
Closed

Extract Encoders to a separate modules #39

Strech opened this issue Jun 19, 2020 · 1 comment
Labels
enhancement Improvement of existing functionality or request of improvement

Comments

@Strech
Copy link
Owner

Strech commented Jun 19, 2020

Technically we have 3 encoders

  1. ObjectContainerFile
  2. Registry
  3. Plain

and Avrora.Encoder knows too much about all the things. After we introduce Avrora.Encoder.extract_schema the duplication of responsibilities and some functions start overlapping.

At the same time, it would be cool to have something like Avrora.Storage behavior.
@Strech Strech added the enhancement Improvement of existing functionality or request of improvement label Jun 19, 2020
@Strech Strech mentioned this issue Aug 13, 2020
Closed
@Strech
Copy link
Owner Author

Strech commented Sep 1, 2020

Closed by #42

@Strech Strech closed this as completed Sep 1, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement Improvement of existing functionality or request of improvement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@Strech