Send multiple messages in one connection #19
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As Django document said, establishing and closing an SMTP connection (or any other network connection, for that matter) is an expensive process. So we should reuse an SMTP connection to send multiple emails, rather than creating and destroying a connection every single email.
This PR change the strategy of sending email. It is no longer sending a task for each email message one by one. It slice the email messages to many of chunks and send a task for each chunk. You can set your own
DJCELERY_SES_CHUNK_SIZE
to control how many email messages you want to send by every single connection.Because of async tasks, it can only get ids of the tasks, instead of the real result of sending mails. So send_messages will return the length of the argument email_messages.