Skip to content
This repository has been archived by the owner on Jun 4, 2021. It is now read-only.

[Feature Request] Add traffic optimization software to boost the speed #723

Closed
HowardMei opened this issue Jun 2, 2017 · 9 comments
Closed

Comments

@HowardMei
Copy link

There are several traffic optimization suites good for speed:
Server & Client: kcptun
Server Side: TCP BBR

Could we have them as an option please?

@cpu
Copy link
Collaborator

cpu commented Jun 2, 2017

Hi @HowardMei - this is a duplicate of #140, so I'm going to close it. Thanks for the suggestion, please follow #140 for that discussion.

@cpu cpu closed this as completed Jun 2, 2017
@cpu cpu reopened this Jun 2, 2017
@cpu
Copy link
Collaborator

cpu commented Jun 2, 2017

Apologies! I commented/closed the wrong feature request. Reopening this one.

@cpu
Copy link
Collaborator

cpu commented Jun 2, 2017

Looking at this again, the TCP BBR request is a duplicate of #546 - which (I believe) is blocked on a kernel dep.

@HowardMei
Copy link
Author

Yeah. It demands kernel 4.9+, but could it be a default off option?
It's not easy do do testing or CI though.

@nickolasclarke
Copy link
Collaborator

@HowardMei is there an advantage of one over the other in terms of performance or featureset? Given that KCP is a standalone project vs BBR, which is an accepted commit to the a future kernel, it seems that from a maintenance standpoint that BBR would be the better option once it is part of a mainstream kernel. It seems that the 18.04 LTS will likely have a kernel version of 4.10+. Once most platforms make 18.04 available as a image option, Streisand could kick over to that and have this by default.

IMO, that probably makes the most sense, given the time commitment that the core contributors can put towards this project at the moment. Others who want the enhanced performance from either option can modify their installations until BBR comes standard.

@HowardMei
Copy link
Author

@nickolasclarke BBR is supported in kernel 4.9+. I chose to implement BBR mode either.
It's in:
https://github.com/HowardMei/dostreisand/tree/develop/playbooks/roles/kernel-upgrade

I also changed some other parts like Vagrantfile/SSHD port that may not be appropriate for pull request.
Therefore, I leave it to you guys to do the cherry-pick.

@cpu
Copy link
Collaborator

cpu commented Jun 29, 2017

I also changed some other parts like Vagrantfile/SSHD port that may not be appropriate for pull request. Therefore, I leave it to you guys to do the cherry-pick.

In general I have to take the difficult position of sharing that our team is very small - we likely don't have the time to pick through commits on a fork to try and cherry-pick a feature commit. If this is a feature you really want to see in the mainline Streisand you'll have to do more of the heavy-lifting to make it as easy as possible for us to review the work & merge it. Chances are you're the expert on your own work and would be able to pick apart the needed pieces much easier than us! Sending a pull request would be the first step! Thanks for understanding.

@HowardMei
Copy link
Author

@cpu Understandable. I'll reconsider.

@cpu
Copy link
Collaborator

cpu commented Jul 23, 2017

Closing in favour of StreisandEffect/discussions#3.

@cpu cpu closed this as completed Jul 23, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

No branches or pull requests

3 participants