Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spec: Multiple Filters / Flexible Meta Details (advanced extra notation) #40

Closed
jaruba opened this issue Dec 10, 2018 · 2 comments
Closed
Assignees
Milestone

Comments

@jaruba
Copy link
Member

jaruba commented Dec 10, 2018

Proposing changes:

manifest {
    catalogs: [
        {
            filters: [
                {
                    name: 'genre',
                    values: [...]
                }, {
                    name: 'platform',
                    values: [...]
                }, {
                    name: 'year',
                    values: [...]
                }
            ],
            extraSupported: [ 'skip', 'genre', 'platform', 'year' ]
        }
     ]
}

We use select boxes for the filters on the Discovery Page instead of one vertical list.

meta {
    details: {
        year: 1997,
        genre: ['Action', 'Shooter'],
        platform: ['PC', 'Mac'],
        description: 'something'
    }
}

We generate the Detail Page based on meta.details.

If a meta.details property is also in extraSupported of the current catalogue, we link it back to the Discovery Page with the filter set.

@jaruba jaruba changed the title Multiple Filters Multiple Filters / Flexible Meta Details Dec 10, 2018
@Ivshti Ivshti changed the title Multiple Filters / Flexible Meta Details [spec] Multiple Filters / Flexible Meta Details Dec 26, 2018
@Ivshti Ivshti self-assigned this Jan 10, 2019
@Ivshti Ivshti changed the title [spec] Multiple Filters / Flexible Meta Details Spec: Multiple Filters / Flexible Meta Details (extraSelectable) Feb 1, 2019
@Ivshti Ivshti transferred this issue from another repository Feb 1, 2019
@Ivshti
Copy link
Member

Ivshti commented Feb 1, 2019

Alternative proposal:

Do this as an extension (verbose syntax) for extraRequired/extraSupported

Rather than extraSupported: ['genre'], we would use extra: [{ name: 'genre', isRequired: false, values: ['Action', 'Comedy'...] }]

Some things to be decided:

  1. is a human friendly name needed
  2. should we have a defaultValue for extraRequired or just assume the first

Then, we only load "complete" (better name: defined/defaultable?) catalogs, which means that they have no extraRequired properties without a default value

@Ivshti Ivshti changed the title Spec: Multiple Filters / Flexible Meta Details (extraSelectable) Spec: Multiple Filters / Flexible Meta Details (advanced extra notation) Feb 10, 2019
@Ivshti
Copy link
Member

Ivshti commented Feb 14, 2019

closing in favour of #49

@Ivshti Ivshti closed this as completed Feb 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants