We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
This line seems to throw if I don't have a public email displayed on my profile, however, I have two invisible emails setup:
https://github.com/Strider-CD/strider-github/blob/master/lib/webapp.js#L169
if (!profile.emails || !profile.emails.length)
What's more, the next line at which an email is used potentially doesn't care if you do have one or not: https://github.com/Strider-CD/strider-github/blob/master/lib/webapp.js#L181
mail: profile.emails ? profile.emails[0].value : null,
So should one have a public email or not?
obviously one of these lines needs to change
The text was updated successfully, but these errors were encountered:
That is correct, you need a public email. Good catch
Sorry, something went wrong.
1b5a7b5
No branches or pull requests
This line seems to throw if I don't have a public email displayed on my profile, however, I have two invisible emails setup:
https://github.com/Strider-CD/strider-github/blob/master/lib/webapp.js#L169
What's more, the next line at which an email is used potentially doesn't care if you do have one or not:
https://github.com/Strider-CD/strider-github/blob/master/lib/webapp.js#L181
So should one have a public email or not?
obviously one of these lines needs to change
The text was updated successfully, but these errors were encountered: