Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Question: Do you need an email address for Github to work? #80

Closed
mishfit opened this issue Aug 9, 2018 · 1 comment
Closed

Question: Do you need an email address for Github to work? #80

mishfit opened this issue Aug 9, 2018 · 1 comment

Comments

@mishfit
Copy link

mishfit commented Aug 9, 2018

This line seems to throw if I don't have a public email displayed on my profile, however, I have two invisible emails setup:

https://github.com/Strider-CD/strider-github/blob/master/lib/webapp.js#L169

if (!profile.emails || !profile.emails.length)

What's more, the next line at which an email is used potentially doesn't care if you do have one or not:
https://github.com/Strider-CD/strider-github/blob/master/lib/webapp.js#L181

mail: profile.emails ? profile.emails[0].value : null,

So should one have a public email or not?

obviously one of these lines needs to change

@knownasilya
Copy link
Member

knownasilya commented Aug 9, 2018

That is correct, you need a public email. Good catch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants