Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Change SEO localization behaviour #400

Closed
2 tasks done
Tracked by #384
Giuseppetm opened this issue Aug 6, 2023 · 1 comment · Fixed by #408
Closed
2 tasks done
Tracked by #384

Change SEO localization behaviour #400

Giuseppetm opened this issue Aug 6, 2023 · 1 comment · Fixed by #408
Assignees
Labels
performance 🚀 Performance related seo 🐲 This issue is related to SEO

Comments

@Giuseppetm
Copy link
Member

Giuseppetm commented Aug 6, 2023

Non-Italian users are a very low percentage so there is no point in taking the language at every request and then rendering it. The performance is still very good but it is not a best practice considering that the site is in fact in Italian by default and can change client-side language if needed.

My proposal is to restore static generation on all pages except for the degree course page that requires ssr.

Pros:

  • Extremely high performance;
  • Improved SEO.

Cons:

  • international users searching for "network studentiunimi" on search engines would get the result in Italian.

To-do

  • Remove global SSR and use italian localization by default;
  • Dialog on client-side (first website visit) to suggest language change.
@Giuseppetm Giuseppetm added needs-approval ⏰ This proposed feature needs to be approved by StudentiUniMi seo 🐲 This issue is related to SEO performance 🚀 Performance related labels Aug 6, 2023
@Giuseppetm Giuseppetm added this to the September 2023 milestone Aug 6, 2023
@Giuseppetm Giuseppetm self-assigned this Aug 13, 2023
@Giuseppetm Giuseppetm removed the needs-approval ⏰ This proposed feature needs to be approved by StudentiUniMi label Aug 14, 2023
@MarcoBuster
Copy link
Member

Feature request: at runtime (client-side), read the Accept-Language header. If 'italian' is not accepted, show a banner in English to guide the user to change the site language.

Also, enable SSR on degree pages would be crazy too 🚀. Maybe with periodic (server-side) refreshing to address db updates.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
performance 🚀 Performance related seo 🐲 This issue is related to SEO
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants