Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Preserving new lines at the end of the template file (fixes #37) #45

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Preserving new lines at the end of the template file (fixes #37) #45

wants to merge 2 commits into from

Conversation

liarco
Copy link

@liarco liarco commented Sep 24, 2021 •
edited

This PR fixes #37.

Implementation details:

  • the comment parser now returns a third array value with the number of new lines at the end of the given comment
  • the initialization function runs the parser before setting the new lines count and EOL format in order to base its decisions on the template file content (if available)
  • tests have been updated to support the new parser feature and check that both UNIX and Windows EOLs work properly

I hope that this can be useful, please feel free to ask for changes or any further information.

Thank you for your time.

@liarco
Copy link
Author

liarco commented Sep 30, 2021

Hi @Stuk, I'm tagging you just to check if this project is still active or not.

Thank you for your time.

@liarco
Copy link
Author

liarco commented Oct 18, 2021

Hi @Stuk, I'm sorry to bother you, but do you have any news about this?

@max-kuzmin
Copy link

max-kuzmin commented Nov 2, 2021 •
edited

@Stuk This is really useful feature

@liarco
Copy link
Author

liarco commented Nov 2, 2021

Thank you @MaxGsomGsom, unfortunately I'm not receiving any feedback from @Stuk. Maybe he's busy or doesn't have the notifications enabled.

@annkupriyanova
Copy link

annkupriyanova commented Nov 3, 2021 •
edited

Cool feature! Thanks, @liarco

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Unable to specify a new line after a header using a template file
3 participants
@liarco @max-kuzmin @annkupriyanova