Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider multi-targetting .NET Core and .NET Framework #9

Open
fernandreu opened this issue Feb 20, 2020 · 1 comment
Open

Consider multi-targetting .NET Core and .NET Framework #9

fernandreu opened this issue Feb 20, 2020 · 1 comment

Comments

@fernandreu
Copy link

Hello,

There is a method incompatibility in ScintillaNET between .NET Framework and .NET Core which
means it needs to be re-targeted if .NET Core needs to be supported (see this issue). As one of my projects using ScintillaNET is also targeting both frameworks, I have gone ahead and created a ScintillaNET fork that supports multi-targeting. It is available here in GitHub and here in NuGet. ScintillaNET.WPF could also support multi-targeting if using this version of ScintillaNET instead.

Now, my project also uses ScintillaNET.WPF, currently as a slightly modified of the project embedded in my solution. However, I was planning to do the same I did with ScintillaNET: fork your repo, make the changes I need, and then release a new NuGet package.

If you are interested in multi-targeting .NET Core and .NET Framework, I could also make the changes I need directly in this repo as pull requests instead.

Regards,
Fernando

@fernandreu
Copy link
Author

FYI, this is now done: https://github.com/fernandreu/ScintillaNET.WPF

This also includes a few extra things I needed for my project, such as a custom automation peer to be able to interact with the control itself (e.g. know what is the text being displayed) during UI tests, and some of the properties being converted to DependencyProperty to be able to perform XAML bindings (e.g. Zoom).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant