better error messages for unknown jobs

flupke · Dec 4, 2017 · 96e8ae0 · 96e8ae0
1 parent a8acc2b
commit 96e8ae0
Show file tree

Hide file tree

Showing 2 changed files with 4 additions and 4 deletions.
diff --git a/jenskipper/cli/decorators.py b/jenskipper/cli/decorators.py
@@ -55,9 +55,9 @@ def wrapper(jobs_names, base_dir, **kwargs):
                 jobs_names = jobs_defs.keys()
             unknown_jobs = set(jobs_names).difference(jobs_defs)
             if unknown_jobs:
-                click.secho('Unknown jobs: %s' % ', '.join(unknown_jobs),
-                            fg='red', bold=True)
-                sys.exit(1)
+                click.secho('Job(s) not found in repository: %s' %
+                            ', '.join(unknown_jobs), fg='red', bold=True)
+                sys.exit(4)
 
             # Filter by dirty jobs
             if dirty_flag and kwargs['use_dirty_jobs']:

diff --git a/jenskipper/cli/status.py b/jenskipper/cli/status.py
@@ -43,7 +43,7 @@ def _print_job_status(base_dir, jenkins_url, job_name, status_only,
                                                         '/job/%s' % job_name)
     except requests.HTTPError as exc:
         if exc.response.status_code == 404:
-            utils.sechowrap('Unkown job: %s' % job_name)
+            utils.sechowrap('Job not found on Jenkins server: %s' % job_name)
             exit_code = 2
         else:
             utils.sechowrap('Unexpected HTTP error %s while trying to '