This repository has been archived by the owner on Jun 1, 2022. It is now read-only.
Update Markdown of OSS. #27
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
leonardssh
suggested changes
Jan 17, 2022
plugins/derlord/OSS.md
Outdated
| { x: 548.0447387695312, y: 2669.48876953125, z: 41.156490325927734, isBlip: true } as IShopLocation, | ||
| { x: 1960.2322998046875, y: 3742.317138671875, z: 31.343746185302734, isBlip: true } as IShopLocation, | ||
| { x: 1730.01171875, y: 6416.22021484375, z: 34.03722381591797, isBlip: true } as IShopLocation, | ||
| { x: 2555.4609375, y: 382.1643371582031, z: 107.62295532226562, isBlip: true } as IShopLocation, |
There was a problem hiding this comment.
Is there a specific purpose why you used as IShopLocation for each item? Once you declare the type of the variable in question, its children will take over the type itself.
I don't see the point in overtyping.
There was a problem hiding this comment.
Overtypes is resolved soon as well, thanks. 👍
| // Used to give all the shops are different blip, just copy the line as often as you need it. | ||
| export const sellersBlips = [ | ||
| { sprite: 52, color: 1, text: 'Seller Example - Index 0', scale: 1 }, // Index 0 | ||
| export const coreShopLocations: IShopLocation[] = [ |
There was a problem hiding this comment.
Shouldn't we also define the types themselves?
There was a problem hiding this comment.
Unsure what this exactly means? 🤔
plugins/derlord/OSS.md
Outdated
| ]; | ||
| const anotherExampleList = [ | ||
| // { Fill me! } -> Index 1 | ||
| export const ShopRegistry: Array<IShop> = [ |
There was a problem hiding this comment.
Same here, where's the type IShop defined?
There was a problem hiding this comment.
Will be resolved soon. Thanks 👍
leonardssh
approved these changes
Jan 17, 2022
Stuyk
suggested changes
Jan 17, 2022
plugins/derlord/OSS.md
Outdated
| ``` | ||
|
|
||
| <img src="https://user-images.githubusercontent.com/82890183/148910952-470985fe-5fed-41ed-8b87-08c9977f71c2.png" width="500"/> | ||
| <img src="https://user-images.githubusercontent.com/82890183/148910952-470985fe-5fed-41ed-8b87-08c9977f71c2.png" width="6500"/> |
Stuyk
approved these changes
Jan 17, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.