Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Inability to use exported documentation (redundant / symbol at the beginning of assets URLs ) #48

Closed
havryliv opened this issue Jan 12, 2021 · 3 comments
Labels
bug Something isn't working Next Release Ready to include in the next release

Comments

@havryliv
Copy link

Describe the bug
Exported documentation (HTML/CSS/JS files) has a redundant / symbol at the beginning of assets URLs which leads to inability to use it.

To Reproduce
Steps to reproduce the behavior:

  1. Execute php artisan enlighten:export command, set any directory and URL.
  2. Open folder where you exported your documentation
  3. Open index.html in the browser ( or host it on the server and open it via URL )
  4. See reproduced issue ( no styles, no scripts loaded and errors in the console - see screenshots section )

Expected behavior
Ability to set any base URL for the exported docs, it might be localhost, https://whatever.com or ./.
Hosted on the server or locally files should work like on Laravel.

Screenshots
Screen Shot 2021-01-12 at 14 36 03
Screen Shot 2021-01-12 at 14 36 24

@havryliv havryliv added the bug Something isn't working label Jan 12, 2021
@sileence
Copy link
Member

Hi @havryliv, what URLs are you using when running the export command? Could you please paste a screenshot of that.

Also what are you using to run the project? It seems you're not using a virtual host and that could be the cause (I haven't tested the export without a virtual host)

@havryliv
Copy link
Author

Hi @sileence
I do not use any virtual host since it's an export for a static usage.
It does not rely on the APP_URL and it's good, having a possibility to set the base URL is needed.

Screenshots
Screen Shot 2021-01-12 at 14 48 05
Screen Shot 2021-01-12 at 14 50 42

@sileence
Copy link
Member

@havryliv I just pushed a fix for this problem in the dev branch, it should be deployed and tagged soon.

@jeffochoa jeffochoa added the Next Release Ready to include in the next release label Feb 4, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working Next Release Ready to include in the next release
Projects
None yet
Development

No branches or pull requests

3 participants