Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

So awesome ! #2

Open
Jurigag opened this issue Oct 22, 2015 · 3 comments
Open

So awesome ! #2

Jurigag opened this issue Oct 22, 2015 · 3 comments

Comments

@Jurigag
Copy link

Jurigag commented Oct 22, 2015

That's gonna help me A FCKING LOT.

But can you add option to define all actions(array) with Resource ? And then if by mistake we define allow for not existing action then we have some information in console.log maybe ?
@StyleT
Copy link
Owner

StyleT commented Oct 22, 2015

I'm glad to see that this library is helpful :)

If you want to add some feature feel free to fork it & send pull request.

Also I don't think that sending information to console log is the right way. Right way: create special exception & throw it. Currently all exceptions have "Error" type, this is mistake that was done because of desire to get "something" working ASAP.

@Jurigag
Copy link
Author

Jurigag commented Oct 23, 2015

I have a question - can getResourceId be just a property ?

@StyleT
Copy link
Owner

StyleT commented Oct 24, 2015

No, only method, since every "resource" entity should implement AclResourceInterface

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@StyleT @Jurigag