Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Contributions calendar do not need svg selector #119

Closed
s890081tonyhsu opened this issue Feb 25, 2014 · 9 comments
Closed

Contributions calendar do not need svg selector #119

s890081tonyhsu opened this issue Feb 25, 2014 · 9 comments

Comments

@s890081tonyhsu
Copy link

s890081tonyhsu commented Feb 25, 2014

bug
I don't know that the bug is just for me.
So I change the code to the following and fix this.
(I deleted "svg|" before "rect". )

#contributions-calendar rect[style="fill: rgb(238, 238, 238);"],
#contributions-calendar rect[style="fill: #eeeeee;"] { fill: #282828 !important }
#contributions-calendar rect[style="fill: rgb(214, 230, 133);"],
#contributions-calendar rect[style="fill: #d6e685;"] { fill: #246 !important }
#contributions-calendar rect[style="fill: rgb(140, 198, 101);"],
#contributions-calendar rect[style="fill: #8cc665;"] { fill: #369 !important }
#contributions-calendar rect[style="fill: rgb(68, 163, 64);"],
#contributions-calendar rect[style="fill: #44a340;"] { fill: #48c !important }
#contributions-calendar rect[style="fill: rgb(30, 104, 35);"],
#contributions-calendar rect[style="fill: #1e6823;"] { fill: #5af !important}
@silverwind
Copy link
Member

I'm not seeing the issue on Firefox here, but it's likely that GitHub changed some code around the calender. I noticed a few white borders below the calender, which I just fixed.

@Mottie do you see it in your Chrome?

@Mottie
Copy link
Member

Mottie commented Feb 25, 2014

Nope... but it does look like they changed some borders around

2014-02-25 16_31_29-mottie rob g

@Mottie
Copy link
Member

Mottie commented Feb 25, 2014

What I have noticed is that if I install a style from userstyles.org, Chrome likes to add the @namespace into a separate section.

2014-02-25 16_35_55-edit style github dark

So I always end up moving those namespaces into the GitHub Dark section, because the @namespace svg definition messes up some other styles that I use, namely the wikipedia dark style I use.

2014-02-25 16_36_18-edit style github dark

@silverwind
Copy link
Member

@s890081tonyhsu The issue is certainly related to the SVG namespace definition. Do you have yours in a seperate section perhaps?

@Mottie
Copy link
Member

Mottie commented Feb 25, 2014

It works without combining the two sections, but like I said, it sometimes messes up other non-GitHub Dark user styles.

@s890081tonyhsu
Copy link
Author

Oh, that's my fault.
I delete it because I don't want it to use in other page.
Thanks for your explain.
But I can't understand why you use svg on chrome, maybe it's unnecessary if I change the code like that.

@Mottie
Copy link
Member

Mottie commented Feb 26, 2014

I mentioned it to the author here... but, all I got was this statement:

Chrome kinda sucks when it comes to @namespace.

so I guess we're stuck with it?

@Mottie Mottie closed this as completed Feb 26, 2014
@silverwind
Copy link
Member

But I can't understand why you use svg on chrome, maybe it's unnecessary if I change the code like that.

Hmm, removing the svg namespace and removing svg| from all selectors might work (and save us a few bytes). Are there any known downsides to doing that?

@Mottie
Copy link
Member

Mottie commented Feb 27, 2014

If I remove the svg|, it breaks that css definition in Chrome.

@Mottie Mottie mentioned this issue Apr 4, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants