Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Atom feed page #214

Closed
silverwind opened this issue Feb 21, 2015 · 7 comments
Closed

Atom feed page #214

silverwind opened this issue Feb 21, 2015 · 7 comments

Comments

@silverwind
Copy link
Member

https://github.com/silverwind.atom

Firefox has some styles of it's own on feed pages, we shouldn't style them. Also, Chrome just displays the xml. Does it really not support feeds?

@silverwind
Copy link
Member Author

Also related: SSH public keys:

https://github.com/silverwind.keys

I think we once had the discussion about styling plaintext (raw urls), and I still think we should do these :)

@Mottie
Copy link
Member

Mottie commented Feb 21, 2015

It looks like most of the Firefox feed is already styled; just an icon and button are missing some stye. And yeah, Chrome doesn't style feeds at all 😞

Honestly, I don't look at raw urls that often, so go ahead and do what you want ;)

@silverwind
Copy link
Member Author

The feed pages crosses a bit too much into browser theme territory for me, also my Firefox theme does some changes to it.

I'll handle the raw URLs thought, can't stand the white flash personally.

@silverwind
Copy link
Member Author

Eh, can't seem to get that regexp right to not match URLs ending in .atom.

@Mottie
Copy link
Member

Mottie commented Feb 22, 2015

I sort of got this to work (added to the bottom, outside of the main definition)

@-moz-document regexp("^https?://github\.com\/.*\.atom$") {
  #feedSubscribeLine * { filter: invert(100%) !important; color: #000 !important; }
}

The "Subscribe to..." with select & "Subscribe Now" button are inside of a <xul:vbox> element, so there isn't any way to style it directly.

@silverwind
Copy link
Member Author

Well that doesn't fix my personal case (with Nasa Night Launch theme), but I guess if we can make it look good on the default theme, that should suffice.

@silverwind
Copy link
Member Author

Just tested on the default style, and it looks fine to me as is, so I don't think any more changes are needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants