New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecation Warnings In Django 3 #43
Comments
@dominik-bln Thanks for reporting this. 🙂 You can merge the first two |
Ok, will do. |
I've opened #45 to address this. @fitodic I've checked again regarding merging the two blocks. From the Django v3 docs it looks like |
Added one more to fix a deprecation of |
Great 👍 |
We recently updated from Django 2 to Django 3 and are now seeing quite a few deprecation warnings regarding
RemovedInDjango40Warning: django.utils.translation.ugettext() is deprecated in favor of django.utils.translation.gettext()
coming from this package.I believe this is caused by the try-catch block in
compat.py
being "reused" for multiple imports where the first line seems to fail in Django 3:https://github.com/Styria-Digital/django-rest-framework-jwt/blob/master/src/rest_framework_jwt/compat.py#L12
It looks like
url
is not part ofdjango.conf
and therefore always raisesImportError
:https://docs.djangoproject.com/en/3.0/ref/urls/
I believe the following should fix the problem in
compat.py
, I'm just not completely sure if the middle block even makes sense or of it should be completely removed:The text was updated successfully, but these errors were encountered: