Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Http.dir doesn't work with UTF8 dir names #85

Closed
haf opened this issue Apr 19, 2014 · 0 comments
Closed

Http.dir doesn't work with UTF8 dir names #85

haf opened this issue Apr 19, 2014 · 0 comments
Assignees
@haf
Labels
bug-major

Comments

@haf
Copy link
Contributor

haf commented Apr 19, 2014

Previous code:

ok (bytes (result.ToString())) ctx

This converts to ASCII which cannot represent all directory names.

New code:

OK (result.ToString()) ctx

I've made the encoding explicit in the Utils module to avoid these sort of bugs again, and by making mentioning the encoding explicit.
@haf haf added the bug-major label Apr 19, 2014
@haf haf self-assigned this Apr 19, 2014
@haf haf closed this as completed in 6731c41 Apr 19, 2014
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@haf haf

Labels
bug-major
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@haf