Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FEATURE] #1208

Open
eugales opened this issue Dec 20, 2022 · 1 comment
Open

[FEATURE] #1208

eugales opened this issue Dec 20, 2022 · 1 comment
Labels
enhancement New feature or request <video> Issues with the <video> tag
Milestone
Priority Goals

Comments

@eugales
Copy link

eugales commented Dec 20, 2022

Use cyrillic url as data source for video player

Solving it with encoding video src with using percent-encoding to make it safe for literal use as a full URI.

flutter_html_video.dart:48
if (attributes['src'] != null) Uri.encodeFull(attributes['src'])

A picture of a cute animal (not mandatory but encouraged)
@eugales eugales added the enhancement New feature or request label Dec 20, 2022
@Sub6Resources Sub6Resources added <video> Issues with the <video> tag in-triage Issue's that I've seen but haven't had a chance to thoroughly review and/or categorize labels May 9, 2023
@Sub6Resources
Copy link
Owner

Thanks for the suggestion. Do you have some examples of cryllic urls that this has worked for?

@Sub6Resources Sub6Resources added this to the Priority Goals milestone May 17, 2023
@Sub6Resources Sub6Resources removed the in-triage Issue's that I've seen but haven't had a chance to thoroughly review and/or categorize label May 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement New feature or request <video> Issues with the <video> tag
Projects
flutter_html Roadmap
Status: Todo
Milestone
Priority Goals
Development

No branches or pull requests
2 participants
@Sub6Resources @eugales