Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] in flutter_html, video full screen can't close when AppBar toolbarHeight changed #817

Closed
Zzy0706 opened this issue Aug 29, 2021 · 5 comments
Labels
bug Something isn't working

Comments

@Zzy0706
Copy link

Zzy0706 commented Aug 29, 2021

Describe the bug:

in flutter_html, video full screen can't close when toolbarHeight changed

HTML to reproduce the issue:
<video controls> <source src="videoUrl" /> </video>

Html widget configuration:

Scaffold( appBar: AppBar( toolbarHeight: 100 - MediaQuery.of(context).padding.top, centerTitle: true, flexibleSpace: Stack( children: [ Image.network( 'https://dummyimage.com/143x142', height: 100, width: 100, fit: BoxFit.cover, ), ], ), ), body:ListView( children: [ // VideoPlayerScreen('videoUrl'), Html( data: htmlData, ),], ) ))
Expected behavior:

close video full screen when AppBar tollBarHeight changed
Screenshots:

first widget,It's outside flutter_html,the second widget is in flutter_html
612bc991d5198_612bc99229443

A picture of a cute animal (not mandatory but encouraged)

IMG_3689

@Zzy0706 Zzy0706 added the bug Something isn't working label Aug 29, 2021
@erickok
Copy link
Collaborator

erickok commented Aug 29, 2021

Hmm. I haven't looked into it in great detail but I think your issue is from the chewie video player project and not flutter_html, as it is chewie who does the video playback including (fake) full screen playback.

@Zzy0706
Copy link
Author

Zzy0706 commented Aug 30, 2021

Hmm. I haven't looked into it in great detail but I think your issue is from the chewie video player project and not flutter_html, as it is chewie who does the video playback including (fake) full screen playback.

Thank you for your reply,This problem only appears in Flutter_html video. if the video outside the Flutter_html ,It will be normal. so....I have no idea

@tneotia
Copy link
Collaborator

tneotia commented Aug 30, 2021

We use a package called chewie_video to render video elements. If it causes a problem in your app, you can always use customRender to make flutter_html copy the implementation you made outside in the other parts of your app.

@Zzy0706
Copy link
Author

Zzy0706 commented Aug 31, 2021

We use a package called chewie_video to render video elements. If it causes a problem in your app, you can always use customRender to make flutter_html copy the implementation you made outside in the other parts of your app.

I used flick_video_player by customRender,but It has the same problem . so,I can only use default toolbarHeight to fix the problem

@tneotia
Copy link
Collaborator

tneotia commented Aug 31, 2021

Wrap the video player in safearea widget and see if it solves the problem

@erickok erickok closed this as completed Nov 29, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

3 participants