Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DependentLookupFieldHandler: Support ID and InternalName (#807) #812

Merged
merged 1 commit into from
Mar 15, 2016
Merged

DependentLookupFieldHandler: Support ID and InternalName (#807) #812

merged 1 commit into from
Mar 15, 2016

Conversation

sebastianmattar
Copy link
Contributor

Fix for #807:

  • Rewrote DependentLookupFieldHandler to have control over which ID and InternalName will be used
  • Minor refactoring regarding field lookups
  • Implemented Test "CanDeploy_DependentLookupField_OnList"
  • Could not get "CanDeployRandom_DependentLookupFieldDefinition" to pass in CSOM, can you have a look?

…nd InternalName will be used

- Minor refactoring regarding field lookups
@SubPointSupport
Copy link
Contributor

Sure, will do. What's the issues with passing random test in CSOM?

@sebastianmattar
Copy link
Contributor Author

Can't get field update validation to work for some fields.
I am pretty sure the code itself is working as my manual tests are successful.

@SubPointSupport
Copy link
Contributor

Thanks, will have a look. No worries.

SubPointSupport added a commit that referenced this pull request Mar 15, 2016
DependentLookupFieldHandler: Support ID and InternalName (#807)
@SubPointSupport SubPointSupport merged commit 74918be into SubPointSolutions:dev Mar 15, 2016
@SubPointSupport
Copy link
Contributor

Both CSOM and SSOM tests fail - the regression tests, and the fields show nothing in the UI. Checking.

@SubPointSupport
Copy link
Contributor

SSOM is fine. Overlooked it. Sorting out the CSOM one. Will be updating #807 as needed.

@sebastianmattar sebastianmattar deleted the hotfix/807 branch August 19, 2016 07:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants