Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prevent unsafe settings of "temp_files_exts" #1417

Closed
lirm-math opened this issue Jul 9, 2019 · 5 comments
Closed

Prevent unsafe settings of "temp_files_exts" #1417

lirm-math opened this issue Jul 9, 2019 · 5 comments

Comments

@lirm-math
Copy link

If someone added some idiot exts (e.g., ".tex" and ".pdf") to "temp_files_exts", when he press "Ctrl+L, Delete", it would be a disaster. Is there a mechanism (like a whitelist) to prevent such dumb settings?

Thank you so much for your reading.

@lirm-math lirm-math changed the title Prevent dumb setting in "temp_files_exts" Prevent unsafe settings of "temp_files_exts" Jul 9, 2019
@ig0774
Copy link
Collaborator

ig0774 commented Jul 9, 2019

Not currently. While I can see there could be some value to something like this, I would be hesitant to make too many assumptions about what other peoples' projects look like.... Maybe (though this is a stretch) the source code is all in .ltx files and the .tex files are generated. In a different vein, it's pretty harmless and, in some cases, maybe even desirable to treat .pdf files as temporary files. They can, after all, be easily regenerated, assuming the .tex source is available.

@lirm-math
Copy link
Author

Some authors prefer to include PDF-images in their tex files, rather thatn JPG or PNG, because JPG and PNG are raster images. Such PDF files are generated with other tools (like Mathematica). If such PDF files are deleted, it would be troublesome to regenerate them.

@lirm-math
Copy link
Author

Would "temp_files_exts_confirmed" be helpful?

I mean, it someone wants to modify "temp_files_exts", he must do it twice. Just like changing the password.

@ig0774
Copy link
Collaborator

ig0774 commented Jul 9, 2019

I'd honestly think it's more worthwhile to add a confirmation prompt to the "Delete Temp Files" command that says "Are you sure?". We could even generate a list of affected files...

@lirm-math
Copy link
Author

I'd honestly think it's more worthwhile to add a confirmation prompt to the "Delete Temp Files" command that says "Are you sure?". We could even generate a list of affected files...

I think this is a good idea.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants