Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Missing dive sites #2749

Closed
3 tasks
p-neves opened this issue Apr 13, 2020 · 1 comment · Fixed by #2759
Closed
3 tasks

Missing dive sites #2749

p-neves opened this issue Apr 13, 2020 · 1 comment · Fixed by #2759
Assignees
@bstoeger
Labels
dive-site release-blocker ui-desktop

Comments

@p-neves
Copy link
Contributor

p-neves commented Apr 13, 2020

Describe the issue:

Dive sites don't show up on the dive sites tab,

  • [X ] Bug
  • Change request
  • New feature request
  • Discussion request

Issue long description:

After starting Subsurface, if one goes to the Dive sites tab, no dive sites show up --- the list is empty.
If I click on "+" button I can populate the list with my dive sites in alphabetical order.

Operating system:

Arch Linux; en-US locale

Subsurface version:

Latest master

Not with an 4.9.2 appimage

self compiled

1438-g9feda560061f

Steps to reproduce:

  1. Start Subsurface
  2. Open a logdive file if none is open by default
  3. Open the Dive sites tab

Current behavior:

The Dive sites tab shows no dive sites

Expected behavior:

All my dive sites should be on the list.

Additional information:

Mentions:
bstoeger added a commit to bstoeger/subsurface that referenced this issue Apr 13, 2020
@bstoeger
dive sites: properly reload dive site model on desktop
c1fc013 
In 9310d72, resetting of the dive
sites was moved to DiveTripModelBase::reset(). This seemed like a
good idea, because it means that the location list is reloaded
every time the dive list is reset.

Unfortunately that function is only used on mobile, thus on desktop
the dive site model is not updated. Do that in
MultiFilterSortModel::resetModel(), because this is always called
when the dive list is reset. Desktop differs from mobile in that
two different models are used depending on whether we are in list
or in tree mode.

Fixes subsurface#2749

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
@bstoeger bstoeger mentioned this issue Apr 13, 2020
Merged
7 tasks
@bstoeger
Copy link
Collaborator

Fix should be in #2759, please test.

@bstoeger bstoeger self-assigned this Apr 13, 2020
dirkhh pushed a commit that referenced this issue Apr 13, 2020
@bstoeger @dirkhh
dive sites: properly reload dive site model on desktop
0ccc0f0 
In 9310d72, resetting of the dive
sites was moved to DiveTripModelBase::reset(). This seemed like a
good idea, because it means that the location list is reloaded
every time the dive list is reset.

Unfortunately that function is only used on mobile, thus on desktop
the dive site model is not updated. Do that in
MultiFilterSortModel::resetModel(), because this is always called
when the dive list is reset. Desktop differs from mobile in that
two different models are used depending on whether we are in list
or in tree mode.

Fixes #2749

Signed-off-by: Berthold Stoeger <bstoeger@mail.tuwien.ac.at>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@bstoeger bstoeger

Labels
dive-site release-blocker ui-desktop
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

dive sites: properly reload dive site model on desktop bstoeger/subsurface
2 participants
@p-neves @bstoeger