Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[idea] Mobile UI #11: Edit Dive / New Dive layout #495

Open
Bocio opened this issue Jul 19, 2017 · 14 comments
Open

[idea] Mobile UI #11: Edit Dive / New Dive layout #495

Bocio opened this issue Jul 19, 2017 · 14 comments

Comments

@Bocio
Copy link

Bocio commented Jul 19, 2017

Previous idea here:
Mobile UI #1: general layout
Mobile UI #2: default action for main screen button
Mobile UI #3: Dive list item layout
Mobile UI #4: Dive list different layouts and menu option
Mobile UI #5: Sidebar
Mobile UI #6: Dive detail title
Mobile UI #7: Dive list EOL and Swipe To Refresh
Mobile UI #8: Sidebar Header
Mobile UI #9: Settings page
Mobile UI #10: Title Bar
All original mockups made with moqups and are online at: (https://app.moqups.com/Bocio/3SSyFCoEwP)

This is the current "new dive" or edit "dive" panel:

screenshot_2017-07-19-23-55-40

I see two problems:

  • Text fields label. They are on the left at the same level of the input line wasting half of the scarce mobile horizontal space.
  • The huge font doesn't help either.

For now I did not modify the number of text fields respect the current edit panel. I changed only the layout trying to get some of Android guidelines on text fields

I will try to resume how it should work:

We a have a simple text field with a label. Labels rest above the line when the text field is empty:

label_resting

Labels float upward and become small when the text field is in focus or filled:

label_floating

Optionally a text field can have a helper text:

helper

For a light theme:
Resting label text is: Type: Roboto 16sp, Color: 54% black (4.5:1 contrast ratio)
Input text is Type: Roboto 16sp, Color: 87% black (15:1 contrast ratio)
Floating label and helper text are: Type: Roboto 12sp Color: 54% black (4.5:1 contrast ratio)

I omit all effects on different text field states... Just be careful at font sizes.
I do not know what is possible with kirigami. I guess they foresee some way to save space.
As last resort we could have small (12sp) labels above the text field with an input font of 16 sp.

subsurface-edit-03

- Dive date edit should open a calendar widget to help user.
- I used a fake helper text on coordinates just to show how it could be useful in some cases to guide the user.

PS

Two questions:

  • In current dive details I do not see tags and stars. Why?
  • How ido i fill cylinders and gas mix? (It's challenging) I see that multiple cylinders are not supported in the mobile app. I have several dives with multiple cylinders but I see only one.
@jbygdell
Copy link
Contributor

Let's see what limitations Kirigami has about this.

For starters Suit, Buddy, Divemaster and Cylinder are not text fields, they are drop-down menus that have an autocomplete function embedded. Since that where the only way to get something to autocomplete with Kirigami 1.0 and QtQuick 1.x.

Since most of the work on the dive display went in just prior to the 1.0 release the mindset where "Let's make it usable" i.e. just add the most mandatory parts.

Star rating is something that could be added to the upper right corner of the dive display.

As for the multiple cylinders issue, let's make that a 2.x feature, we have enough to get the UI streamlined as it is.

@Bocio
Copy link
Author

Bocio commented Jul 20, 2017

For starters Suit, Buddy, Divemaster and Cylinder are not text fields, they are drop-down menus that have an autocomplete function embedded. Since that where the only way to get something to autocomplete with Kirigami 1.0 and QtQuick 1.x.

Then I was the perfect guinea pig for these controls. They look as standard text fields so I did not try to use them.

Star rating is something that could be added to the upper right corner of the dive display.

Yes

As for the multiple cylinders issue, let's make that a 2.x feature, we have enough to get the UI streamlined as it is.

I agree

@dirkhh
Copy link
Collaborator

dirkhh commented Jul 21, 2017 via email

@Bocio
Copy link
Author

Bocio commented Jul 22, 2017

Again, not something I ever contemplated. There is so much insane complexity in this. So many weird special cases. Happy to look at patches,
but not something I'm going to tackle

Dirk it was just a question :) I didn't even realize it was a dropbox...

@dirkhh
Copy link
Collaborator

dirkhh commented Jul 22, 2017 via email

@jbygdell
Copy link
Contributor

Stars enabled.

screenshot 13

@dirkhh
Copy link
Collaborator

dirkhh commented Jul 28, 2017

I am rather worried that your backyard pool has only 4 star viz...
Other than that... NICE.

jbygdell added a commit to jbygdell/subsurface that referenced this issue Jul 28, 2017
Display rating and visibility stars on the dive details page. See subsurface#495

Signed-off-by: Joakim Bygdell <j.bygdell@gmail.com>
@jbygdell
Copy link
Contributor

Unfortunately there is no date/time picker in QT so that one need to be created if we intend to use one.

jbygdell added a commit to jbygdell/subsurface that referenced this issue Jul 31, 2017
Display rating and visibility stars on the dive details page. See subsurface#495

Signed-off-by: Joakim Bygdell <j.bygdell@gmail.com>
@jbygdell
Copy link
Contributor

Oh, and hiding the action button is not possible, it is hard coded as visible in Kirigami once it is active on a page. I have asked Marco about the logic on this choice.
It's just a one line fix in Kirigami.

@Bocio
Copy link
Author

Bocio commented Jul 31, 2017

One tragic line fix actually

Despite of feasability did you like my idea?

@Bocio
Copy link
Author

Bocio commented Jul 31, 2017

Never mind. I thought you were commenting on the alternate layout.

@dirkhh
Copy link
Collaborator

dirkhh commented Jul 31, 2017

@jbygdell has Marco responded? Worst case, we can carry that one liner in Subsurface and apply it after cloning Kirigami. We've done far worse than this.

@jbygdell
Copy link
Contributor

@dirkhh no respone yet, I just sent the question 10min ago.

@dirkhh
Copy link
Collaborator

dirkhh commented Jul 31, 2017

Ha. You can also try to catch him on freenode - he's "notmart" and is usually in the #plasma channel - but I see right now he's not there. Of course he's Italian and it's summer - so he might be gone for three weeks :-)

jbygdell added a commit to jbygdell/subsurface that referenced this issue Jul 31, 2017
Display rating and visibility stars on the dive details page. See subsurface#495

Signed-off-by: Joakim Bygdell <j.bygdell@gmail.com>
dirkhh pushed a commit that referenced this issue Aug 3, 2017
Display rating and visibility stars on the dive details page. See #495

Signed-off-by: Joakim Bygdell <j.bygdell@gmail.com>
dirkhh added a commit that referenced this issue Oct 5, 2017
This way the accidental closing of the edit (and loss of data)
should no longer happen.

See: #495

Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

4 participants