Heat Map at Surface #2027
Heat Map at Surface #2027
Conversation
core/planner.c
Outdated
| current_cylinder = i; | ||
| break; | ||
| } | ||
| plan_add_segment(diveplan, 600, 0, current_cylinder, 0, false, OC); |
There was a problem hiding this comment.
adding this unconditional, instead of as an option. Hmm. Interesting. I didn't expect that.
There was a problem hiding this comment.
UI is added in second commit as you will see. This first commit is to get the logic right.
profile-widget/diveeventitem.cpp
Outdated
| if (result.isEmpty()) { | ||
| Q_ASSERT("can't find a spot in the dataModel"); | ||
| hide(); | ||
| return -666; |
There was a problem hiding this comment.
The number of the beast as an error number is cute... but I'd prefer something with a symbolic name that is then checked by the caller... because the caller above uses this as a depth (admittedly just to compare against a constant, but still... worst case return "-1" which you define as "ABOVE_SURFACE")
There was a problem hiding this comment.
I needed some out of bounds special value to signal error (before, when this was part of the other function which is of type void, this was simply a return;.
-1 would not really work (yes, I just realised that the conditional below should take that into account) as that is a valid depth value of a somewhat noisy depth sensor. So I needed a more negative number. But yes, that should be a constant...
profile-widget/diveeventitem.cpp
Outdated
| void DiveEventItem::recalculatePos(bool instant) | ||
| { | ||
| if (!vAxis || !hAxis || !internalEvent || !dataModel) | ||
| return; | ||
|
|
||
|
|
profile-widget/diveeventitem.cpp
Outdated
| QModelIndexList result = dataModel->match(dataModel->index(0, DivePlotDataModel::TIME), Qt::DisplayRole, internalEvent->time.seconds); | ||
| if (result.isEmpty()) { | ||
| Q_ASSERT("can't find a spot in the dataModel"); | ||
| hide(); | ||
| return; | ||
| } | ||
| int depth = depthAtTime(internalEvent->time.seconds); | ||
| if (depth < 0) |
There was a problem hiding this comment.
and then here you could compare with == to your symbolic constant
There was a problem hiding this comment.
I should definitely test against the constant (which should be negative enough not to be a possible value of a depth sensor)
CHANGELOG.md
Outdated
| @@ -1,3 +1,4 @@ | |||
| - Planner: Allow for a final dive segment at the surface | |||
There was a problem hiding this comment.
I'm being picky, but is this a "dive" segment or is this a "deco" segment?
There was a problem hiding this comment.
Will do. Expect an update tonight (old world time).
to display the deco parameters at the surface, in particular tissue saturation and heat map. Suggeted-by: Matthias Heinrichs <info@heinrichsweikamp.com> Signed-off-by: Robert C. Helling <helling@atdotde.de>
Signed-off-by: Robert C. Helling <helling@atdotde.de>
Signed-off-by: Robert C. Helling <helling@atdotde.de>
|
Rebased on current master and addressed comments. |
it creapt in through the gaschange events. Signed-off-by: Robert C. Helling <helling@atdotde.de>
Describe the pull request:
Pull request long description:
Part of the decompression is done at the surface while breathing air again. This PR adds the possibility to show this in the planner by extending the dive by a final segment at zero depth breathing air. This way, tissue saturations and in particular the heat map becomes visible after reaching the surface.
Changes made:
Related issues:
Additional information:
Release note:
Documentation change:
Mentions: