App image combined #2300
Merged
App image combined #2300
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
September 22, 2019 14:18
Add ssl to the AppImage build. Add helper script to fetch required dependancies. Update docker build container used. Signed-off-by: Paul Buxton <paubuxton.mail@googlemail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
When building dbus within the appimage, cmake picks up the installation path of various files dbus uses through the GNUInstallDirs package, however this doesn't work under the appimage build. So we replace the variable with the normal location of this file. Signed-off-by: Paul Buxton <paubuxton.mail@googlemail.com> Signed-off-by: Dirk Hohndel <dirk@hohndel.org>
dirkhh
force-pushed
the
AppImageCombined
branch
from
449138b
to
f4d30e1
Compare
|
Hmm, I don't seem to be able to find the build. |
|
Sorry - PR builds aren't populated back to the GitHub site. You need to look through the build log to find the transfer.sh address. |
|
Thanks, will have a look. It will be tomorrow before I can try it on my
creaky old work system :-)
…On Mon, Sep 23, 2019 at 4:16 PM Dirk Hohndel ***@***.***> wrote:
Sorry - PR builds aren't populated back to the GitHub site. You need to
look through the build log to find the transfer.sh address.
Please try this:
https://transfer.sh/CF17k/Subsurface-4.9.3-71-g10d662aa52a8-x86_64.AppImage
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#2300>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/AEVOI3HMX6ERWWCUKFTGJODQLDMUJANCNFSM4IZEWHXQ>
.
|
|
Based on the positive feedback (and my own successful tests) I'll merge this. |
This was referenced Sep 23, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Describe the pull request:
Pull request long description:
This is a combination of #2296 and #2298 by @buxtonpaul
I updated the reference to the 0.7 docker image based on his code. The only reason I'm pushing them as a combined PR is so that we can test the resulting AppImage and make sure nothing got broken compared to Paul's testing.
Mentions:
@buxtonpaul please take a look at the AppImage that is created as a result of the Travis run and make sure that it works for you